Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: adding expect reponse to connection closed #38

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

danlavu
Copy link

@danlavu danlavu commented Aug 22, 2023

No description provided.

@justin-stephenson
Copy link
Contributor

Hi Dan, can you remove the other 2 commits from this PR? Otherwise Ack from me.

@danlavu
Copy link
Author

danlavu commented Aug 22, 2023

@justin-stephenson , mark it approved and I'll rebase it as the others get merged?

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I won't approve until the other two PRs are merged. I'll review them again to check what's missing to merge them.

@danlavu
Copy link
Author

danlavu commented Aug 23, 2023

@justin-stephenson, Now that I'm no longer testing the test code, I remove all irrelevant PRs. This is good to go now.

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Thank you.

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch!

@ikerexxe ikerexxe merged commit 273552f into SSSD:master Aug 24, 2023
2 checks passed
@danlavu danlavu deleted the ssh-connection-closed branch April 17, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants